Messages in this thread Patch in this message | | | Date | Tue, 8 Jul 2008 09:42:08 -0700 | From | Arjan van de Ven <> | Subject | [patch 4/17] Use WARN() in kernel/irq/manage.c |
| |
From: Arjan van de Ven <arjan@linux.intel.com>
Replace a printk+WARN_ON() by a WARN(); this increases the chance of the string making it into the bugreport (ie: it goes inside the ---[ cut here ]--- section)
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@elte.hu> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> ---
kernel/irq/manage.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
Index: linux.trees.git/kernel/irq/manage.c =================================================================== --- linux.trees.git.orig/kernel/irq/manage.c +++ linux.trees.git/kernel/irq/manage.c @@ -177,8 +177,7 @@ static void __enable_irq(struct irq_desc { switch (desc->depth) { case 0: - printk(KERN_WARNING "Unbalanced enable for IRQ %d\n", irq); - WARN_ON(1); + WARN(1, KERN_WARNING "Unbalanced enable for IRQ %d\n", irq); break; case 1: { unsigned int status = desc->status & ~IRQ_DISABLED; @@ -247,9 +246,7 @@ int set_irq_wake(unsigned int irq, unsig set_wake = NULL; } else { if (desc->wake_depth == 0) { - printk(KERN_WARNING "Unbalanced IRQ %d " - "wake disable\n", irq); - WARN_ON(1); + WARN(1, "Unbalanced IRQ %d wake disable\n", irq); } else if (--desc->wake_depth == 0) desc->status &= ~IRQ_WAKEUP; else
| |