Messages in this thread Patch in this message | | | Date | Tue, 8 Jul 2008 09:51:08 -0700 | From | Arjan van de Ven <> | Subject | [patch 10/17] use WARN() in arch/x86/mm/pageattr.c |
| |
From: Arjan van de Ven <arjan@linux.intel.com> Subject: Use WARN instead of printk+WARN_ON in x86/mm/pageattr
Use WARN() instead of a printk+WARN_ON() pair; this way the message becomes part of the warning section for better reporting/collection.
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com> Acked-by: Ingo Molnar <mingo@elte.hu>
--- arch/x86/mm/pageattr-test.c | 3 +-- arch/x86/mm/pageattr.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)
Index: linux.trees.git/arch/x86/mm/pageattr.c =================================================================== --- linux.trees.git.orig/arch/x86/mm/pageattr.c +++ linux.trees.git/arch/x86/mm/pageattr.c @@ -586,10 +586,9 @@ repeat: if (!pte_val(old_pte)) { if (!primary) return 0; - printk(KERN_WARNING "CPA: called for zero pte. " + WARN(1, KERN_WARNING "CPA: called for zero pte. " "vaddr = %lx cpa->vaddr = %lx\n", address, cpa->vaddr); - WARN_ON(1); return -EINVAL; } Index: linux.trees.git/arch/x86/mm/pageattr-test.c =================================================================== --- linux.trees.git.orig/arch/x86/mm/pageattr-test.c +++ linux.trees.git/arch/x86/mm/pageattr-test.c @@ -221,8 +221,7 @@ static int pageattr_test(void) failed += print_split(&sc); if (failed) { - printk(KERN_ERR "NOT PASSED. Please report.\n"); - WARN_ON(1); + WARN(1, KERN_ERR "NOT PASSED. Please report.\n"); return -EINVAL; } else { if (print)
| |