Messages in this thread Patch in this message | | | Date | Tue, 8 Jul 2008 09:46:35 -0700 | From | Arjan van de Ven <> | Subject | [patch 6/17] Use WARN() in mm/vmalloc.c |
| |
From: Arjan van de Ven <arjan@linux.intel.com> Subject: Use WARN instead of printk+WARN_ON in mm/vmalloc.c
Use WARN() instead of a printk+WARN_ON() pair; this way the message becomes part of the warning section for better reporting/collection.
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com> --- mm/vmalloc.c | 6 2 files changed, 2 insertions(+), 309 deletions(-)
Index: linux.trees.git/mm/vmalloc.c =================================================================== --- linux.trees.git.orig/mm/vmalloc.c +++ linux.trees.git/mm/vmalloc.c @@ -381,16 +381,14 @@ static void __vunmap(const void *addr, i return; if ((PAGE_SIZE-1) & (unsigned long)addr) { - printk(KERN_ERR "Trying to vfree() bad address (%p)\n", addr); - WARN_ON(1); + WARN(1, KERN_ERR "Trying to vfree() bad address (%p)\n", addr); return; } area = remove_vm_area(addr); if (unlikely(!area)) { - printk(KERN_ERR "Trying to vfree() nonexistent vm area (%p)\n", + WARN(1, KERN_ERR "Trying to vfree() nonexistent vm area (%p)\n", addr); - WARN_ON(1); return; }
| |