Messages in this thread | | | Date | Mon, 7 Jul 2008 22:31:58 +0200 | From | "Vegard Nossum" <> | Subject | Re: [PATCH] rc80211_pid: Fix fast_start parameter handling |
| |
Hi,
On Mon, Jul 7, 2008 at 10:23 PM, Mattias Nissler <mattias.nissler@gmx.de> wrote: > This removes the fast_start parameter from the rc_pid parameters information > and instead uses the parameter macro when initializing the rc_pid state. Since the > parameter is only used on initialization, there is no point of making exporting > it via debugfs. This also fixes uninitialized memory references to the > fast_start and norm_offset parameters. > > Signed-off-by: Mattias Nissler <mattias.nissler@gmx.de> > --- > > This should fix the problem. I think this should go into mainline ASAP.
Was this code actually causing some problem/regression? If so, can we please have a reference to bugzilla/prior conversations in the patch description?
Was the reason for the problem known before I posted the "use of uninitialized memory" e-mail earlier today? If no, can you please sneak in a little reference to kmemcheck there in the patch description? The acknowledgement is sorely needed :-)
Thanks!
Vegard
-- "The animistic metaphor of the bug that maliciously sneaked in while the programmer was not looking is intellectually dishonest as it disguises that the error is the programmer's own creation." -- E. W. Dijkstra, EWD1036
| |