lkml.org 
[lkml]   [2008]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Ocfs2-devel] [BUGFIX][PATCH 1/2] configfs: Prevent userspace from creating new entries under attaching directories
On Thu, Jul 03, 2008 at 02:58:56PM -0700, Joel Becker wrote:
> On Thu, Jun 26, 2008 at 08:05:48PM +0200, Louis Rilling wrote:
> > This commit fixes 1/, tagging new directories with CONFIGFS_USET_CREATING before
> > building the inode and instantiating the dentry, and validating the whole
> > group+default groups hierarchy in a second pass by clearing
> > CONFIGFS_USET_CREATING.
>
> Man, I'm wary of all these in-flight flags. I hope they are all
> orthogonal :-)

Yes they are :)

>
> > mkdir(), symlink(), lookup(), and dir_open() simply return -ENOENT if
> > called in (or linking to) a directory tagged with CONFIGFS_USET_CREATING. This
>
> Why not block until the create is done?

Hm, I think that we can't without risking deadlocks.

- mkdir(): we can only hit CONFIGFS_USET_CREATING when called inside a default
group A/.../B of a new group A being attached. We hold B's i_mutex from
sys_mkdirat(). We must not block because this could deadlock with
detach_groups() in case the new group A fails to attach all its default
groups.
- symlink(): same issue as mkdir(), plus the fact that it is not possible to
block on the target of symlink(), because of potential deadlocks with
lock_rename().
- lookup(): same issue as mkdir().
- dir_open(): same issue as mkdir().

>
> > + /*
> > + * Fake invisibility if dir belongs to a group/default groups hierarchy
> > + * being attached
> > + *
> > + * This forbids userspace to read/write attributes of items which may
> > + * not complete their initialization, since the dentries of the
> > + * attributes won't be instantiated.
> > + */
> int configfs_dirent_is_ready(struct configfs_dirent *sd)
> {
> int err = 0;
> > + spin_lock(&configfs_dirent_lock);
> > + if (parent_sd->s_type & CONFIGFS_USET_CREATING)
> > + err = -ENOENT;
> > + spin_unlock(&configfs_dirent_lock);
> return err;
> }
>
> Then use is_ready() in the five places you check it ;-) Perhaps
> change configfs_validate_dir() to configfs_dir_set_ready(). I do like
> the way validate_dir() is coded.

Ok. I'll resend the patchset with this change.

Louis

--
Dr Louis Rilling Kerlabs
Skype: louis.rilling Batiment Germanium
Phone: (+33|0) 6 80 89 08 23 80 avenue des Buttes de Coesmes
http://www.kerlabs.com/ 35700 Rennes
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2008-07-04 13:15    [W:0.062 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site