lkml.org 
[lkml]   [2008]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 3/5] of-bindings: Add binding documentation for SPI busses and devices
Date
> +    The SPI master node requires the following properties:
> + - #address-cells - number of cells required to define a chip
> select
> + address on the SPI bus.

Hrm. Should this (and "reg" in the child node) be required for SPI
masters that have only one chip select?

> + - max-speed - (required) Maximum SPI clocking speed of
> device in Hz

The property name should include something "SPI", it's way too generic
otherwise.

> + - spi,cpol - (optional) Device requires inverse clock
> polarity
> + - spi,cpha - (optional) Device requires shifted clock phase

Don't abbr the property names, there's nothing wrong with longer names.
The names shouldn't start with "spi," either, "spi" isn't a vendor;
how about "spi-inverse-clock-polarity" or similar?

> + - linux,modalias - (optional, Linux specific) Force binding of
> SPI device
> + to a particular spi_device driver. Useful for changing
> + driver binding between spidev and a kernel SPI driver.

This is a temporary workaround I hope?


Segher



\
 
 \ /
  Last update: 2008-07-05 01:39    [W:0.097 / U:0.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site