Messages in this thread | | | Subject | Re: [PATCH -mm] fix ipr-use-memory_read_from_buffer.patch | From | James Bottomley <> | Date | Fri, 04 Jul 2008 12:05:36 -0500 |
| |
On Sat, 2008-07-05 at 01:54 +0900, Akinobu Mita wrote: > Now memory_read_from_buffer() belongs in string.h > > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> > Cc: Brian King <brking@us.ibm.com> > Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com> > --- > drivers/scsi/ipr.c | 1 + > 1 file changed, 1 insertion(+) > > Index: 2.6-mm/drivers/scsi/ipr.c > =================================================================== > --- 2.6-mm.orig/drivers/scsi/ipr.c > +++ 2.6-mm/drivers/scsi/ipr.c > @@ -71,6 +71,7 @@ > #include <linux/module.h> > #include <linux/moduleparam.h> > #include <linux/libata.h> > +#include <linux/string.h> > #include <asm/io.h> > #include <asm/irq.h> > #include <asm/processor.h>
This isn't really necessary, is it? As you can see from the file being stuffed full of memcpy directives, it's already getting an implicit include of string.h from somewhere (like the rest of the SCSI drivers).
James
| |