Messages in this thread | | | Subject | Re: [PATCH 4/5] byteorder: fix direct byteswap includes | From | Harvey Harrison <> | Date | Fri, 04 Jul 2008 09:37:53 -0700 |
| |
On Fri, 2008-07-04 at 16:37 +0100, David Howells wrote: > Harvey Harrison <harvey.harrison@gmail.com> wrote: > > > +#include <asm/byteorder.h> > > Please use <linux/byteorder.h> rather than <asm/byteorder.h> when including > stuff from .c files outside the include and arch directories.
asm/byteorder.h is the file included everywhere else, and before my patches, linux/byteorder.h didn't even exist. Thus, when preparing my patches I made sure that including asm/byteorder.h continued to be the way to get this functionality.
I could add another patch on top that makes linux/byteorder the one we want included and search/replace the existing asm includes, but I thought that was a bit too big to do in one go.
If people think this is the way to go, I'll prepare a patch to change the includes.
> And whilst you're at it, Documentation/byteorder.txt is yours for the > creation:-)
Already working on an update to unaligned_access.txt, I'll get to byteorder next.
Harvey
| |