Messages in this thread |  | | | Date | Thu, 31 Jul 2008 23:56:14 +0100 | | From | Alan Cox <> | | Subject | Re: [PATCH] drivers/net/skfp/pmf.c: Use offsetof() macro |
On Thu, 31 Jul 2008 18:55:06 +0200
Takashi Iwai <tiwai@suse.de> wrote:
> Self-baked macros cause bunch of compile warnings like below:
>
> CC [M] drivers/net/skfp/pmf.o
> CC net/ipv4/fib_semantics.o
> drivers/net/skfp/pmf.c:86: warning: cast from pointer to integer of different size
> drivers/net/skfp/pmf.c:87: warning: cast from pointer to integer of different size
> ...
>
> Use the standard offsetof() macro instead.
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Alan Cox <alan@redhat.com>
(And this is better than the patch I sent to netdev so Ack in definite
preference to the one I posted)
|  |