lkml.org 
[lkml]   [2008]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 26/29] ath5k: dont enable MSI, we cannot handle it yet
    2.6.25-stable review patch.  If anyone has any objections, please let us 
    know.

    ------------------
    From: Pavel Roskin <proski@gnu.org>

    commit 256b152b005e319f985f50f2a910a75ba0def74f upstream

    MSI is a nice thing, but we cannot enable it without changing the
    interrupt handler. If we do it, we break MSI capable hardware,
    specifically AR5006 chipset.

    Signed-off-by: Pavel Roskin <proski@gnu.org>
    Acked-by: Nick Kossifidis <mickflemm@gmail.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/net/wireless/ath5k/base.c | 5 -----
    1 file changed, 5 deletions(-)

    --- a/drivers/net/wireless/ath5k/base.c
    +++ b/drivers/net/wireless/ath5k/base.c
    @@ -484,9 +484,6 @@ ath5k_pci_probe(struct pci_dev *pdev,
    /* Set private data */
    pci_set_drvdata(pdev, hw);

    - /* Enable msi for devices that support it */
    - pci_enable_msi(pdev);
    -
    /* Setup interrupt handler */
    ret = request_irq(pdev->irq, ath5k_intr, IRQF_SHARED, "ath", sc);
    if (ret) {
    @@ -553,7 +550,6 @@ err_ah:
    err_irq:
    free_irq(pdev->irq, sc);
    err_free:
    - pci_disable_msi(pdev);
    ieee80211_free_hw(hw);
    err_map:
    pci_iounmap(pdev, mem);
    @@ -575,7 +571,6 @@ ath5k_pci_remove(struct pci_dev *pdev)
    ath5k_detach(pdev, hw);
    ath5k_hw_detach(sc->ah);
    free_irq(pdev->irq, sc);
    - pci_disable_msi(pdev);
    pci_iounmap(pdev, sc->iobase);
    pci_release_region(pdev, 0);
    pci_disable_device(pdev);
    --


    \
     
     \ /
      Last update: 2008-07-31 01:45    [W:0.046 / U:0.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site