Messages in this thread | | | Subject | Re: [PATCH] paravirt_ops: Use unsigned long instead of u32 for alloc_p*() pfn args | From | Zachary Amsden <> | Date | Wed, 30 Jul 2008 14:59:53 -0700 |
| |
On Wed, 2008-07-30 at 14:51 -0700, Jeremy Fitzhardinge wrote: > Eduardo Habkost wrote: > > This patch changes the pfn args from 'u32' to 'unsigned long' > > on alloc_p*() functions on paravirt_ops, and the corresponding > > implementations for Xen and VMI. The prototypes for CONFIG_PARAVIRT=n > > are already using unsigned long, so paravirt.h now matches the prototypes > > on asm-x86/pgalloc.h. > > > > It shouldn't result in any changes on generated code on 32-bit, with > > or without CONFIG_PARAVIRT. On both cases, 'codiff -f' didn't show any > > change after applying this patch. > > > > On 64-bit, there are (expected) binary changes only when CONFIG_PARAVIRT > > is enabled, as the patch is really supposed to change the size of the > > pfn args. > > > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > > > Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> > > Cc:ing Zach, since it touches vmi.
Thanks, looks good to me. I always thought u32 is ugly type name anyway.
Acked-by: Zachary Amsden <zach@vmware.com>
| |