lkml.org 
[lkml]   [2008]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] cpumask: Change cpumask_of_cpu to use cpumask_of_cpu_map
On Wed, Jul 30, 2008 at 11:37:52AM -0700, Mike Travis wrote:

> >> I've lost the plot on what's going on with these cpumask patches.
> >> But I just saw this on -rc1.
> >>
> >> arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c:206:33: error: not addressable
> >> arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c:274:32: error: not addressable
> >> arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c:352:34: error: not addressable
> >>
>
> After I recreated linux-next the changes all appear to be there now.
> One problem though, is !SMP config does not build (something about
> DECLARE_BITMAP with NR_CPUS=1.) I wasn't sure how to create a constant
> "(cpumask_t)1" that worked as an lvalue, so the following patch is
> somewhat a kluge, but fulfills the requirements.
>
> If anyone has a better suggestion, please let me know.
>
> Subject: [PATCH] cpmask: add cpumask_of_cpu(0) for non-SMP
>
> * Fix cpumask_of_cpu(0) when CONFIG_SMP is not set by providing a
> pointer to a cpumask_t with cpu 0 bit set.

confused. I saw the error above with a make allyesconfig, which
sets CONFIG_SMP=y

Dave

--
http://www.codemonkey.org.uk


\
 
 \ /
  Last update: 2008-07-30 20:53    [W:0.118 / U:0.152 seconds]
©2003-2014 Jasper Spaans. Advertise on this site