Messages in this thread | | | Date | Wed, 30 Jul 2008 20:46:03 +0200 | From | Karsten Keil <> | Subject | Re: [PATCH] mISDN cleanup user interface |
| |
On Wed, Jul 30, 2008 at 08:37:21PM +0200, Sam Ravnborg wrote: > On Wed, Jul 30, 2008 at 07:51:38PM +0200, Karsten Keil wrote: > > On Wed, Jul 30, 2008 at 05:57:01PM +0100, David Woodhouse wrote: > > > On Wed, 2008-07-30 at 18:33 +0200, Karsten Keil wrote: > > > > What about this implementation ? > > > > > > Looks a lot saner... although it does seem to confirm my earlier > > > suspicion that you're not even _using_ the fact that it's a bitmap at > > > all. You set the bits for the present channels at init time, which are > > > always contiguous, and you never seem to change them them later -- why > > > couldn't you do this with a simple 'number of channels' integer? > > > > No it is not contineous on different PRI line setups (E1,T1 ...) > > e.g a E1 has the D-channel on channel 15 position, so this bit is not set > > then. > timeslot 16 in my book actually - but maybe that your timeslot to > channel mapping. >
You are correct of course.
-- Karsten Keil SuSE Labs ISDN and VOIP development SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
| |