lkml.org 
[lkml]   [2008]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [-mm][PATCH 1/10] fix UNEVICTABLE_LRU and !PROC_PAGE_MONITOR build
    On Wed, 25 Jun 2008 19:01:40 +0900 KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:

    >
    > =
    > From: Rik van Riel <riel@redhat.com>
    >
    > Both CONFIG_PROC_PAGE_MONITOR and CONFIG_UNEVICTABLE_LRU depend on
    > mm/pagewalk.c being built. Create a CONFIG_PAGE_WALKER Kconfig
    > variable that is automatically selected if needed.
    >
    > Debugged-by: Benjamin Kidwell <benjkidwell@yahoo.com>
    > Signed-off-by: Rik van Riel <riel@redhat.com>
    > Signed-off-by: KOSAKI Motohiro <kosaki@jp.fujitsu.com>
    >
    > ---
    > init/Kconfig | 1 +
    > mm/Kconfig | 5 +++++
    > mm/Makefile | 2 +-
    > 3 files changed, 7 insertions(+), 1 deletion(-)
    >
    > Index: b/init/Kconfig
    > ===================================================================
    > --- a/init/Kconfig
    > +++ b/init/Kconfig
    > @@ -803,6 +803,7 @@ source "arch/Kconfig"
    > config PROC_PAGE_MONITOR
    > default y
    > depends on PROC_FS && MMU
    > + select PAGE_WALKER
    > bool "Enable /proc page monitoring" if EMBEDDED
    > help
    > Various /proc files exist to monitor process memory utilization:

    You used select! With the usual consequences.

    mm/pagewalk.c: In function `walk_pud_range':
    mm/pagewalk.c:64: error: implicit declaration of function `pud_none_or_clear_bad'
    mm/pagewalk.c: In function `walk_page_range':
    mm/pagewalk.c:119: error: implicit declaration of function `pgd_addr_end'
    mm/pagewalk.c:120: error: implicit declaration of function `pgd_none_or_clear_ba

    That's SuperH allmodconfig. I expect all nommu builds are busted.

    > Index: b/mm/Kconfig
    > ===================================================================
    > --- a/mm/Kconfig
    > +++ b/mm/Kconfig
    > @@ -209,9 +209,14 @@ config VIRT_TO_BUS
    > def_bool y
    > depends on !ARCH_NO_VIRT_TO_BUS
    >
    > +# automatically selected by UNEVICTABLE_LRU or PROC_PAGE_MONITOR
    > +config PAGE_WALKER
    > + def_bool n
    > +
    > config UNEVICTABLE_LRU
    > bool "Add LRU list to track non-evictable pages"
    > default y
    > + select PAGE_WALKER

    So what do we do? Make UNEVICTABLE_LRU depend on CONFIG_MMU? That
    would be even worse than what we have now.



    \
     
     \ /
      Last update: 2008-07-03 10:55    [W:0.036 / U:31.264 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site