lkml.org 
[lkml]   [2008]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Bug 10868] Oops on loading ipaq module since 2.6.26, prevents use of device
On Thu, Jul 03, 2008 at 04:26:48PM +0200, Oliver Neukum wrote:
> Am Donnerstag 03 Juli 2008 16:20:30 schrieb Adrian Bunk:
> > On Thu, Jul 03, 2008 at 04:08:44PM +0200, Oliver Neukum wrote:
> > > Am Donnerstag 03 Juli 2008 10:57:33 schrieb Adrian Bunk:
>
> > > > --- a/drivers/usb/serial/ipaq.c
> > > > +++ b/drivers/usb/serial/ipaq.c
> > > > @@ -571,9 +571,9 @@ static struct usb_serial_driver ipaq_device = {
> > > > .usb_driver = &ipaq_driver,
> > > > .id_table = ipaq_id_table,
> > > > .num_interrupt_in = NUM_DONT_CARE,
> > > > - .num_bulk_in = 1,
> > > > - .num_bulk_out = 1,
> > > > - .num_ports = 1,
> > > > + .num_bulk_in = NUM_DONT_CARE,
> > > > + .num_bulk_out = NUM_DONT_CARE,
> > >
> > > This is good.
> >
> > These fields are removed by a later commit in 2.6.26... 8-)
>
> Well, NUM_DONT_CARE is default, so it makes no difference, but a comment
> would have been nice.

They were removed from struct usb_serial_driver in
include/linux/usb/serial.h since the checks they were used for caused
more problems than they solved.

But you are right that the effects of the removal are the same as
NUM_DONT_CARE.

> Regards
> Oliver

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed



\
 
 \ /
  Last update: 2008-07-03 17:03    [W:0.491 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site