lkml.org 
[lkml]   [2008]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: linux-next: build failure

    * Stephen Rothwell <sfr@canb.auug.org.au> wrote:

    > Hi Dave,
    >
    > Today's linux-next build (sparc64 defconfig) failed like this:
    >
    > kernel/time/tick-common.c: In function `tick_check_new_device':
    > kernel/time/tick-common.c:210: error: invalid lvalue in unary `&'
    > kernel/time/tick-common.c:223: error: invalid lvalue in unary `&'
    > kernel/time/tick-common.c:255: error: invalid lvalue in unary `&'
    >
    > gcc is version 3.4.5 sparc64 cross compiler (powercp64 host).
    >
    > The below patch fixes it.
    >
    > when you take the address of the result. Noticed on a sparc64 compile
    > using a version 3.4.5 cross compiler.
    >
    > kernel/time/tick-common.c: In function `tick_check_new_device':
    > kernel/time/tick-common.c:210: error: invalid lvalue in unary `&'
    > kernel/time/tick-common.c:223: error: invalid lvalue in unary `&'
    > kernel/time/tick-common.c:255: error: invalid lvalue in unary `&'
    >
    > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
    > ---
    > include/linux/cpumask.h | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h
    > index 96d0509..d3219d7 100644
    > --- a/include/linux/cpumask.h
    > +++ b/include/linux/cpumask.h
    > @@ -287,7 +287,7 @@ static inline const cpumask_t *get_cpu_mask(unsigned int cpu)
    > * gcc optimizes it out (it's a constant) and there's no huge stack
    > * variable created:
    > */
    > -#define cpumask_of_cpu(cpu) ({ *get_cpu_mask(cpu); })
    > +#define cpumask_of_cpu(cpu) (*get_cpu_mask(cpu))

    hm, i'm wondering - is this a compiler bug?

    Ingo


    \
     
     \ /
      Last update: 2008-07-29 10:03    [W:0.023 / U:33.528 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site