Messages in this thread | | | Subject | Re: [PATCH] cpuset: Rework sched domains and CPU hotplug handling | From | Peter Zijlstra <> | Date | Tue, 29 Jul 2008 08:40:54 +0200 |
| |
On Mon, 2008-07-28 at 16:07 +0200, Ingo Molnar wrote: > * Max Krasnyansky <maxk@qualcomm.com> wrote: > > > Max Krasnyansky wrote: > > > This is an updated version of my previous cpuset patch: > > > "Make rebuild_sched_domains() usable from any context (take 2)" > > > > Folks, > > > > Any comments on this patch ? We need this to complete sched domain > > handling fixes/improvements that we started with the cpu_active_map, > > and to avoid circular locking issues in the cpu hotplug -> > > rebuild_sched_domains path. > > Paul, Peter, any comments?
I'm really not that at home with all that cgroup fiddling, so I'd like a word from the two Pauls..
Questions I have at the moment:
- do we really need a new workqueue for this? Can't we use the regular keventd stuff, now that Oleg fixed the get_online_cpus() thing? (3da1c84c00c7e5fa8348336bd8c342f9128b0f14)
- aren't there funny races with the async_rebuild_sched_domains() stuff?
| |