lkml.org 
[lkml]   [2008]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: module-placed markers/tracepoints
Date
On Wednesday 30 July 2008 08:41:16 Mathieu Desnoyers wrote:
> Therefore, what would be needed here is to add a synchronize_sched()
> after mod->exit() in module.c or after each tracepoint/marker unregister
> in marker.c/tracepoint.c. However, I'd really prefer to add this to
> module.c since adding this for _every_ unregister will slow down
> processing or multiple probe unregistration too much.
>
> Rusty, am I understanding that correctly ?
>
> Mathieu

Hi Mathieu,

Yes: stop_machine is merely used to atomically check the module refcount
for zero and set the state so it can't be incremented again (ie.
try_module_get will fail).

So placing a tracepoint or marker in a module does not bump the module
refcount? If that's true, then there needs to be some kind of
remove_markers_from_module() call after module->exit(), which should do the
synchronize_sched() or whatever, right?

Rusty.


\
 
 \ /
  Last update: 2008-07-30 03:43    [W:0.134 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site