Messages in this thread | | | Date | Wed, 30 Jul 2008 00:26:22 +0100 | From | Alan Cox <> | Subject | Re: pci_ids.h - duplicate entry and many out of order definitions |
| |
On Wed, 30 Jul 2008 09:00:09 +1000 "David Wilson" <mcs6502@gmail.com> wrote:
> I was browsing the pci_ids.h file and came across a duplicate entry > for PCI_VENDOR_ID_RDC. This prompted me to look further and I found a > number of out-of-order definitions (based on the comment at the head > of the file that indicates that they should be sorted). I decided to > write a script to check this and it found 74 "errors". > > 1) Is it worth my time generating a patch to fix all these mis-orderings? > 2) Should it be one large patch or many small ones (eg one per PCI_VENDOR)? > 3) Is there a maintainer for this file?
1. Yes 2. It depends how big the patch is. I like the idea of one per vendor sorting the vendor device entries into order and one then putting the vendors in order. That would be easy to check/read 3. jbarnes@virtuousgeek.org
(in theory. I don' t know if he thinks its his file yet ;))
| |