lkml.org 
[lkml]   [2008]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] Remove stray <6> in BogoMIPS printk

    * Joe Perches <joe@perches.com> wrote:

    > On Sun, 2008-07-27 at 23:47 +0530, Rabin Vincent wrote:
    > > Remove the extra KERN_INFO which causes this:
    > > Calibrating delay loop... <6>179.40 BogoMIPS (lpj=897024)
    > > - printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
    > > - loops_per_jiffy/(500000/HZ),
    > > - (loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
    > > + printk("%lu.%02lu BogoMIPS (lpj=%lu)\n",
    > > + loops_per_jiffy/(500000/HZ),
    > > + (loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
    > > }
    >
    > How about just using KERN_CONT and leaving the whitespace
    > for a patch that does the entire file?
    >
    > diff --git a/init/calibrate.c b/init/calibrate.c
    > index 7963e3f..51c5cec 100644
    > --- a/init/calibrate.c
    > +++ b/init/calibrate.c
    > @@ -170,7 +170,7 @@ void __cpuinit calibrate_delay(void)
    > loops_per_jiffy &= ~loopbit;
    > }
    > }
    > - printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
    > + printk(KERN_CONT "%lu.%02lu BogoMIPS (lpj=%lu)\n",
    > loops_per_jiffy/(500000/HZ),
    > (loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);

    ok - i've applied the patch below. Please send the full-file cleanup as
    a separate patch if anyone is interested in doing it.

    Ingo

    ------------>
    From d7ba11d01cfedf63b50391fbe4a05274b6992b43 Mon Sep 17 00:00:00 2001
    From: Joe Perches <joe@perches.com>
    Date: Sun, 27 Jul 2008 12:02:04 -0700
    Subject: [PATCH] x86: remove stray <6> in BogoMIPS printk

    Rabin Vincent noticed that there's a stray <6> in BogoMIPS printk:

    > Remove the extra KERN_INFO which causes this:
    > Calibrating delay loop... <6>179.40 BogoMIPS (lpj=897024)
    > - printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
    > - loops_per_jiffy/(500000/HZ),
    > - (loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
    > + printk("%lu.%02lu BogoMIPS (lpj=%lu)\n",
    > + loops_per_jiffy/(500000/HZ),
    > + (loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
    > }

    How about just using KERN_CONT and leaving the whitespace
    for a patch that does the entire file?

    Reported-by: Rabin Vincent <rabin@rab.in>
    ---
    init/calibrate.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/init/calibrate.c b/init/calibrate.c
    index 7963e3f..a379c90 100644
    --- a/init/calibrate.c
    +++ b/init/calibrate.c
    @@ -170,7 +170,7 @@ void __cpuinit calibrate_delay(void)
    loops_per_jiffy &= ~loopbit;
    }
    }
    - printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
    + printk(KERN_CONT "%lu.%02lu BogoMIPS (lpj=%lu)\n",
    loops_per_jiffy/(500000/HZ),
    (loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
    }

    \
     
     \ /
      Last update: 2008-07-28 14:27    [W:0.028 / U:1.060 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site