lkml.org 
[lkml]   [2008]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: mISDN still breaking the allmodconfig build...
    On Mon, Jul 28, 2008 at 10:20:09AM +0100, Alan Cox wrote:
    > On Sun, 27 Jul 2008 20:48:05 -0400
    > Sean MacLennan <smaclennan@pikatech.com> wrote:
    >
    > > On Mon, 28 Jul 2008 10:13:42 +1000
    > > "Benjamin Herrenschmidt" <benh@kernel.crashing.org> wrote:
    > >
    > > > On Sun, 2008-07-27 at 17:02 -0700, David Miller wrote:
    > > > > More fallout from the premature mISDN driver merge:
    > > > >
    > > > > drivers/isdn/hardware/mISDN/hfcmulti.c:5255:2: error: #error "not
    > > > > running on big endian machines now"
    > > >
    > > > Lovely...
    > >
    > > mISDN is notoriously bad on big endian machines.
    >

    This only affect the hardware IO layer of some cards and I think
    it will be fixed very soon, I did not remove the very old
    #error line, because I did not had the hardware to verify that it is
    OK now.
    I already reserved a PPC machine now (will get it today or tomorrow) and
    will test the endian robustness this week.

    > In which case it really should not be in Linus tree but in linux-next.
    > Karsten - will you ask Linus to revert mISDN so it can go into linux-next
    > instead and get cleaned up in the right place ?
    >

    This was my original plan and my fault, that I only included the
    pull URL and sent it to Linus diectely, I did not know that in this case
    Linus will pull it without further discussion, but I'm still glad that it
    is in and only show few issues (I'm very unhappy that I did not find
    these before, I did builds on all our architectures, but not with the
    all*config, only with subsets).
    The good thing is, that this brought back the ENDIAN issue back on my
    radar and on my near time TODO list :-)

    --
    Karsten Keil
    SuSE Labs
    ISDN and VOIP development
    SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)


    \
     
     \ /
      Last update: 2008-07-28 13:17    [W:0.022 / U:153.696 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site