Messages in this thread | | | Date | Tue, 29 Jul 2008 09:30:38 +0800 | From | Li Zefan <> | Subject | Re: [PATCH 1/3] cpuset: clean up cpuset hierarchy traversal code |
| |
Paul Jackson wrote: > Li Zefan wrote: >> - q = kfifo_alloc(number_of_cpusets * sizeof(cp), GFP_KERNEL, NULL); > > > The block comment for rebuild_sched_domains() states: > >> ... May take callback_mutex during >> * call due to the kfifo_alloc() and kmalloc() calls. > > I suspect that mention of kfifo_alloc() is no longer correct, > with your patch. If so, perhaps you could send a little additional > fix patch, to remove that mention from the comment. >
Yes, but I just noticed Max removes that comment completely in his patch, so I guess I can leave it as it is.
| |