Messages in this thread | | | Date | Tue, 29 Jul 2008 00:05:33 +0100 | From | Ralf Baechle <> | Subject | Re: [PATCH 1/1] Char: ds1286, eliminate busy waiting |
| |
On Fri, Jul 25, 2008 at 07:49:58PM +0200, Jiri Slaby wrote:
> ds1286_get_time(); is not called from atomic context, sleep for 20 ms is > better choice than a (home-made) busy waiting for such a situation. > > Signed-off-by: Jiri Slaby <jirislaby@gmail.com> > Cc: Ralf Baechle <ralf@linux-mips.org>
Looks ok to me I guess. Though I don't really think it matters ...
Acked-by: Ralf Baechle <ralf@linux-mips.org>
The same condition also appears in drivers/char/rtc.c and maybe a few others. Rtc.c has been copies and modified several times.
Ralf
| |