lkml.org 
[lkml]   [2008]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] Char: ds1286, eliminate busy waiting
On Fri, Jul 25, 2008 at 07:49:58PM +0200, Jiri Slaby wrote:

> ds1286_get_time(); is not called from atomic context, sleep for 20 ms is
> better choice than a (home-made) busy waiting for such a situation.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>

Looks ok to me I guess. Though I don't really think it matters ...

Acked-by: Ralf Baechle <ralf@linux-mips.org>

The same condition also appears in drivers/char/rtc.c and maybe a few
others. Rtc.c has been copies and modified several times.

Ralf


\
 
 \ /
  Last update: 2008-07-29 01:11    [W:0.076 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site