Messages in this thread | | | From | kamezawa.hiroyu@jp ... | Date | Mon, 28 Jul 2008 17:39:14 +0900 (JST) | Subject | Re: Re: [PATCH 1/2][-mm][resend] res_counter limit change support ebusy |
| |
----- Original Message ----- >On Mon, 14 Jul 2008 17:11:54 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fuji tsu.com> wrote: > >> +static inline int res_counter_set_limit(struct res_counter *cnt, >> + unsigned long long limit) >> +{ >> + unsigned long flags; >> + int ret = -EBUSY; >> + >> + spin_lock_irqsave(&cnt->lock, flags); >> + if (cnt->usage < limit) { >> + cnt->limit = limit; >> + ret = 0; >> + } >> + spin_unlock_irqrestore(&cnt->lock, flags); >> + return ret; >> +} > >Need I say it? This function is waaaaaay too large to be inlined.
Will rework and make this uninlined. (in this week)
Thanks, -Kame
| |