Messages in this thread | | | Date | Mon, 28 Jul 2008 13:46:24 -0700 | From | Jeremy Fitzhardinge <> | Subject | Re: [PATCH 1/1] mm: unify pmd_free() implementation |
| |
Andrew Morton wrote: > I can second that. See > http://userweb.kernel.org/~akpm/mmotm/broken-out/include-asm-generic-pgtable-nopmdh-macros-are-noxious-reason-435.patch > > Ingo cruelly ignored it. Probably he's used to ignoring the comit > storm which I send in his direction - I'll need to resend it sometime. > > I'd consider that patch to be partial - we should demacroize the > surrounding similar functions too. But that will require a bit more > testing.
Its immediate neighbours should be easy enough (pmd_alloc_one, __pmd_free_tlb), but any of the ones involving pmd_t risk #include hell (though the earlier references to pud_t in inline functions suggest it will work). And pmd_addr_end is just ugly.
J
| |