lkml.org 
[lkml]   [2008]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] mm: unify pmd_free() implementation
Andrew Morton wrote:
> I can second that. See
> http://userweb.kernel.org/~akpm/mmotm/broken-out/include-asm-generic-pgtable-nopmdh-macros-are-noxious-reason-435.patch
>
> Ingo cruelly ignored it. Probably he's used to ignoring the comit
> storm which I send in his direction - I'll need to resend it sometime.
>
> I'd consider that patch to be partial - we should demacroize the
> surrounding similar functions too. But that will require a bit more
> testing.

Its immediate neighbours should be easy enough (pmd_alloc_one,
__pmd_free_tlb), but any of the ones involving pmd_t risk #include hell
(though the earlier references to pud_t in inline functions suggest it
will work). And pmd_addr_end is just ugly.

J



\
 
 \ /
  Last update: 2008-07-28 22:49    [W:0.066 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site