lkml.org 
[lkml]   [2008]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/3] PCI: Handle 64-bit resources better on 32-bit machines
    Date
    If the kernel is configured to support 64-bit resources on a 32-bit
    machine, we can support 64-bit BARs properly. Just change the condition
    to check sizeof(resource_size_t) instead of BITS_PER_LONG.

    Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
    ---
    drivers/pci/probe.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
    index 3b690c3..2036300 100644
    --- a/drivers/pci/probe.c
    +++ b/drivers/pci/probe.c
    @@ -270,10 +270,10 @@ static int __pci_read_base(struct pci_dev *dev, enum pci_bar_type type,
    if (!sz64)
    goto fail;

    - if ((BITS_PER_LONG < 64) && (sz64 > 0x100000000ULL)) {
    + if ((sizeof(resource_size_t) < 8) && (sz64 > 0x100000000ULL)) {
    dev_err(&dev->dev, "can't handle 64-bit BAR\n");
    goto fail;
    - } else if ((BITS_PER_LONG < 64) && l) {
    + } else if ((sizeof(resource_size_t) < 8) && l) {
    /* Address above 32-bit boundary; disable the BAR */
    pci_write_config_dword(dev, pos, 0);
    pci_write_config_dword(dev, pos + 4, 0);
    --
    1.5.5.4


    \
     
     \ /
      Last update: 2008-07-28 19:41    [W:0.072 / U:62.192 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site