lkml.org 
[lkml]   [2008]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] cpuset: clean up cpuset hierarchy traversal code
Paul Jackson wrote:
> Li Zefan wrote:
>> - q = kfifo_alloc(number_of_cpusets * sizeof(cp), GFP_KERNEL, NULL);
>
>
> The block comment for rebuild_sched_domains() states:
>
>> ... May take callback_mutex during
>> * call due to the kfifo_alloc() and kmalloc() calls.
>
> I suspect that mention of kfifo_alloc() is no longer correct,
> with your patch. If so, perhaps you could send a little additional
> fix patch, to remove that mention from the comment.
>

Paul, please take a look at
cpuset: Rework sched domains and CPU hotplug handling
patch I sent out last week.
I'd appreciate if we applied that one first. It simplifies lock nesting
and rearranges the way sched domains are rebuilt. It is IMO a bit higher
priority than this patch because scheduler depends on the
rebuild_sched_domains() call and we have to call rebuild_sched_domains()
from cpu hotplug handlers.

Max



\
 
 \ /
  Last update: 2008-07-28 19:23    [W:0.073 / U:1.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site