lkml.org 
[lkml]   [2008]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: move ehci reg def
* Greg KH <greg@kroah.com> wrote:

> On Sat, Jul 26, 2008 at 04:18:13PM +0200, Ingo Molnar wrote:
> >
> > * Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> >
> > > >> +#include <linux/usb/ehci_def.h>
> > > >>
> > > >> /*-------------------------------------------------------------------------*/
> > > >>
> > > >> +
> > > >
> > > > Only one blank line needed please. ;)
> > >
> > > thanks.
> > > Greg, Do i need to resend ?
> >
> > i've fixed it up - see updated patch below.
> >
> > Greg, could you please pull this change from the tip/usb-for-greg git
> > tree:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git usb-for-greg
> >
> > so that we can share the commit ID, without you having to carry
> > unrelated x86 fixes? I'll merge this tree too into x86/early-printk.
>
> I only use git for sending stuff to Linus, so that will not really
> work.

oh, didnt know that.

> I have no objection for you keeping this in your tree, as that
> probably makes it easier.

okay - i just wanted to keep your options maximally flexible, it's code
you maintain, we are just trespassing :)

the commit will eventually show up in linux-next via tip/auto-x86-next.

Given that it's all pretty uncontroversial, we might as well send it
upstream after -rc1 - this is an isolated debug feature. (and a much
desired one to begin with. We could even get printks out of terminally
hung suspend/resume laptops this way i think!)

Any objections to that course of action?

Ingo


\
 
 \ /
  Last update: 2008-07-28 18:13    [W:0.077 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site