Messages in this thread | | | Date | Mon, 28 Jul 2008 01:01:41 -0500 | From | Paul Jackson <> | Subject | Re: [PATCH 1/3] cpuset: clean up cpuset hierarchy traversal code |
| |
Li Zefan wrote: > - q = kfifo_alloc(number_of_cpusets * sizeof(cp), GFP_KERNEL, NULL);
The block comment for rebuild_sched_domains() states:
> ... May take callback_mutex during > * call due to the kfifo_alloc() and kmalloc() calls.
I suspect that mention of kfifo_alloc() is no longer correct, with your patch. If so, perhaps you could send a little additional fix patch, to remove that mention from the comment.
-- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.940.382.4214
| |