lkml.org 
[lkml]   [2008]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [2.6 patch] linux/swap.h must #include <linux/pagemap.h>
    On Sat, Jul 26, 2008 at 10:05:34PM +0100, Hugh Dickins wrote:
    > On Sat, 26 Jul 2008, Adrian Bunk wrote:
    > > On Sat, Jul 26, 2008 at 09:37:45PM +0100, Hugh Dickins wrote:
    > > >
    > > > I've trespassed on Adrian's good nature to ask him to run some builds
    > > > on it, having demonstrated my incompetence twice already. But he may
    > > > well have better things to do with his time. Hold on a mo, I'm just
    > > > wrapping up the tmpfs BUG first.
    > >
    > > Sorry, if you wanted to know anything from me anything except whether my
    > > patch is correct (as I already answered to Johannes it is not) I must
    > > have missed it.
    > >
    > > What exactly do you want me to test?
    >
    > It was this one, just including pagemap.h back in exec.c again:
    > not the best solution, but should be good for now. Please would
    > you give it the build testing you were giving yours? Or feel free
    > to point out that I'm wasting your and everybody's time, and just
    > call for a straight revert of ba92a43d, that'd be fine too.
    >
    > Thanks,
    > Hugh
    >
    > --- 2.6.26-git/fs/exec.c 2008-07-26 12:33:28.000000000 +0100
    > +++ linux/fs/exec.c 2008-07-26 18:50:38.000000000 +0100
    > @@ -32,6 +32,7 @@
    > #include <linux/swap.h>
    > #include <linux/string.h>
    > #include <linux/init.h>
    > +#include <linux/pagemap.h>
    > #include <linux/highmem.h>
    > #include <linux/spinlock.h>
    > #include <linux/key.h>

    No problems found, patch works fine.

    cu
    Adrian

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed



    \
     
     \ /
      Last update: 2008-07-27 15:07    [W:0.039 / U:0.032 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site