Messages in this thread |  | | | Date | Sun, 27 Jul 2008 16:15:40 +0400 | | From | Oleg Nesterov <> | | Subject | Q: wait_task_inactive() and !CONFIG_SMP && CONFIG_PREEMPT |
| |
Without CONFIG_SMP wait_task_inactive() is noop, this doesn't look right. Shouldn't we also take CONFIG_PREEMPT into account?
Not that it really matters, just curious. kthread_bind() itself could be noop without CONFIG_SMP. ptrace_check_attach() shouldn't have real problems, but still.
Also, the !SMP version of wait_task_inactive() always returns 1, this doesn't conform to the comment near kernel/sched.c:wait_task_inactive().
Oleg.
|  |