Messages in this thread |  | | | Date | Mon, 28 Jul 2008 10:32:53 +1000 | | From | Stephen Rothwell <> | | Subject | Re: [PATCH] powerpc/ibmveth: fix multiple errors with dma_mapping_error conversion |
| |
Hi Andrew,
On Sun, 27 Jul 2008 12:24:14 -0700 Andrew Morton <akpm@linux-foundation.org> wrote: > > On Mon, 28 Jul 2008 02:14:24 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > The addition of an argument to dma_mapping_error() in commit > > 8d8bb39b9eba32dd70e87fd5ad5c5dd4ba118e06 "dma-mapping: add the device > > argument to dma_mapping_error()" left a bit of fallout: > > Yeah, sorry, that patch was a horror - I fixed it perhaps ten times. I > think people were madly adding new dma_mapping_error() calls while we > were trying to maintain it as well. > > It should have been dome as a two-stage conversion.
Yes, indeed (my new favourite word :-))
I hope that we all can discuss procedures for API changes at the Kernel Summit ...
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [unhandled content-type:application/pgp-signature] |  |