lkml.org 
[lkml]   [2008]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 4/4] remove <linux/hdreg.h>
Date
On Thursday 24 July 2008, Christoph Hellwig wrote:
> On Thu, Jul 24, 2008 at 10:11:52PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Thursday 24 July 2008, Christoph Hellwig wrote:
> > > On Thu, Jul 24, 2008 at 09:37:58PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > > > It has no in-kernel users now and can be removed.
> > >
> > > But beeing an exported header it has userspace users. Plese keep it
> > > and just leave the ioctl defintions as need by userspace in it instead
> > > of renaming that part to hdio_ioctls.h.
> >
> > Agreed w.r.t. to keeping it (the last patch was more of rfc than intended
> > to be commited, sorry that I didn't mark it as such) but what's wrong with
> > moving ioctl definitions to hdio_ioctls.h so we have clean separation of
> > obsoleted userspace-only stuff & userspace/kernel stuff?
>
> Well, if there was anything kernel-related left in hdreg.h I would
> agree to split it, although I'd prefer to move the kernel part out.
>
> But given that you kill all the kernel only bits anyway, just leave
> the user interface in hdreg.h even if it's slightly misnamed.

Yep, no need to move it around. I reworked patchset accordingly.

Thanks,
Bart


\
 
 \ /
  Last update: 2008-07-27 17:39    [from the cache]
©2003-2011 Jasper Spaans