lkml.org 
[lkml]   [2008]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 22/24] x86/oprofile: Add CONFIG_OPROFILE_IBS option

* Robert Richter <robert.richter@amd.com> wrote:

> +config OPROFILE_IBS
> + bool "OProfile AMD IBS support (EXPERIMENTAL)"
> + default n
> + depends on OPROFILE && SMP && X86
> + help
> + Instruction-Based Sampling (IBS) is a new profiling
> + technique that provides rich, precise program performance
> + information. IBS is introduced by AMD Family10h processors
> + (AMD Opteron Quad-Core processor ???Barcelona???) to overcome
> + the limitations of conventional performance counter
> + sampling.

weird UTF characters in the description - please try to use ASCII in
such general Kconfig help-texts.

also, it would be nice to have a pure technical description. I.e.
something like:

> + Instruction-Based Sampling (IBS) is a new hardware feature
> + that provides precise, non-statistical profiling
> + information. IBS is available in AMD Family10h processors.
> + (AMD Barcelona).

> +#ifdef CONFIG_OPROFILE_IBS
> op_amd_handle_ibs(regs, msrs);
> +#endif

please hide #ifdefs by making the op_amd_handle_ibs() function general.

Ingo


\
 
 \ /
  Last update: 2008-07-26 12:17    [from the cache]
©2003-2011 Jasper Spaans