Messages in this thread | | | Date | Sat, 26 Jul 2008 18:48:05 -0700 | From | "Yinghai Lu" <> | Subject | Re: [PATCH] usb: don't hide bios bug warning |
| |
On Sat, Jul 26, 2008 at 6:24 PM, Greg KH <gregkh@suse.de> wrote: > On Sat, Jul 26, 2008 at 06:12:15PM -0700, Yinghai Lu wrote: >> >> quirk_usb_disable_handoff will wait a while if there is BIOS bug. >> let the end user know the reason for that. >> >> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> >> >> --- >> drivers/usb/host/pci-quirks.c | 9 ++++++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) >> >> Index: linux-2.6/drivers/usb/host/pci-quirks.c >> =================================================================== >> --- linux-2.6.orig/drivers/usb/host/pci-quirks.c >> +++ linux-2.6/drivers/usb/host/pci-quirks.c >> @@ -190,7 +190,8 @@ static void __devinit quirk_usb_handoff_ >> msleep(10); >> } >> if (wait_time <= 0) >> - dev_warn(&pdev->dev, "OHCI: BIOS handoff failed" >> + dev_printk(KERN_WARNING, &pdev->dev, >> + "OHCI: BIOS handoff failed" > > This is the exact same thing here, no change. > >> @@ -242,7 +243,8 @@ static void __devinit quirk_usb_disable_ >> switch (cap & 0xff) { >> case 1: /* BIOS/SMM/... handoff support */ >> if ((cap & EHCI_USBLEGSUP_BIOS)) { >> - dev_dbg(&pdev->dev, "EHCI: BIOS handoff\n"); >> + dev_printk(KERN_DEBUG, &pdev->dev, >> + "EHCI: BIOS handoff\n"); > > Is this what you really want to see? But you just made things noiser. > >> @@ -283,7 +285,8 @@ static void __devinit quirk_usb_disable_ >> /* well, possibly buggy BIOS... try to shut >> * it down, and hope nothing goes too wrong >> */ >> - dev_warn(&pdev->dev, "EHCI: BIOS handoff failed" >> + dev_printk(KERN_WARNING, &pdev->dev, >> + "EHCI: BIOS handoff failed" > > This is the exact same thing, no change. > > confused,
end user will not set CONFIG_USB_DEBUG, so that dev_warn will do nothing.
YH
| |