Messages in this thread Patch in this message | | | Date | Sat, 26 Jul 2008 16:46:17 +0100 | From | Tomas Janousek <> | Subject | [PATCH] rtc-dev: stop periodic interrupts on device release |
| |
Solves http://bugzilla.kernel.org/show_bug.cgi?id=11127
The old rtc.c driver did it, some drivers (like rtc-sh) do it in their release function too, but rtc-cmos does not -- because it provides the irq_set_state op -- so the rtc framework itself should care about it. This patch makes it do so.
I am aware that some drivers, like rtc-sh, handle userspace PIE sets in their ioctl op, exporting the irq_set_state op at the same time. The logic in rtc_irq_set_state should make sure it doesn't matter and the driver should not need to care stopping periodic interrupts in its release routine any more. I did not look at other drivers though.
Signed-off-by: Tomas Janousek <tomi@nomi.cz> Cc: Alessandro Zummo <alessandro.zummo@towertech.it> Cc: David Brownell <david-b@pacbell.net> --- drivers/rtc/rtc-dev.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/rtc/rtc-dev.c b/drivers/rtc/rtc-dev.c index 90dfa0d..6fafa62 100644 --- a/drivers/rtc/rtc-dev.c +++ b/drivers/rtc/rtc-dev.c @@ -408,6 +408,8 @@ static int rtc_dev_release(struct inode *inode, struct file *file) #ifdef CONFIG_RTC_INTF_DEV_UIE_EMUL clear_uie(rtc); #endif + rtc_irq_set_state(rtc, NULL, 0); + if (rtc->ops->release) rtc->ops->release(rtc->dev.parent); -- 1.5.6
-- Tomáš Janoušek, a.k.a. Liskni_si, http://work.lisk.in/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |