lkml.org 
[lkml]   [2008]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: BUILD_IRQ say .text to avoid .data.percpu

* Hugh Dickins <hugh@veritas.com> wrote:

> When I edit the x86_64 Makefile to -fno-unit-at-a-time, bootup panics
> on 0xCCs in IRQ0x3e_interrupt(): IRQ0x20_interrupt etc. have got linked
> into .data.percpu. Perhaps there are other ways of triggering that:
> specify ".text" in the BUILD_IRQ() macro for safety.
>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>

applied to tip/x86/urgent, thanks Hugh.

> I've been using -fno-unit-at-a-time (to lessen inlining, for easier
> debugging) for a long time, but never saw this until Mike's percpu
> mods came in: I mention this so you're on the lookout, just in case
> other things are more likely to go into the wrong section now. (I did
> give Mike a private headsup on this a couple of weeks ago, in case it
> helped with problems he was having with percpu, but in fact it didn't
> help.)

Should we perhaps enable this automatically on CONFIG_FRAME_POINTER=y
builds? Although a separate, default-off config option might be better,
i'd not be surprised if there were more regressions in this area, it's a
seldom used build vector.

Ingo


\
 
 \ /
  Last update: 2008-07-24 12:47    [W:0.102 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site