Messages in this thread | | | Subject | Re: [PATCH -next] kmemcheck: include module.h to prevent warnings | From | Pekka Enberg <> | Date | Fri, 25 Jul 2008 02:27:03 +0300 |
| |
On Thu, 2008-07-24 at 16:09 -0700, Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > kmemcheck/shadow.c needs to include <linux/module.h> to prevent > the following warnings: > > linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : data definition has no type or storage class > linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' > linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : parameter names (without types) in function declaration > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Looks good to me.
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
> --- > arch/x86/mm/kmemcheck/shadow.c | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20080724.orig/arch/x86/mm/kmemcheck/shadow.c > +++ linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c > @@ -1,5 +1,6 @@ > #include <linux/kmemcheck.h> > #include <linux/mm.h> > +#include <linux/module.h> > > #include <asm/page.h> > #include <asm/pgtable.h> > > > --- > ~Randy > Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA > http://linuxplumbersconf.org/
| |