Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 4/4] remove <linux/hdreg.h> | Date | Thu, 24 Jul 2008 22:11:52 +0200 |
| |
On Thursday 24 July 2008, Christoph Hellwig wrote: > On Thu, Jul 24, 2008 at 09:37:58PM +0200, Bartlomiej Zolnierkiewicz wrote: > > It has no in-kernel users now and can be removed. > > But beeing an exported header it has userspace users. Plese keep it > and just leave the ioctl defintions as need by userspace in it instead > of renaming that part to hdio_ioctls.h.
Agreed w.r.t. to keeping it (the last patch was more of rfc than intended to be commited, sorry that I didn't mark it as such) but what's wrong with moving ioctl definitions to hdio_ioctls.h so we have clean separation of obsoleted userspace-only stuff & userspace/kernel stuff?
[ The hdio_ioctls.h include is also exported to userspace and included by hdreg.h internally (patch #1) so userspace should be unaffected. ]
Thanks, Bart
| |