Messages in this thread | | | Date | Thu, 24 Jul 2008 08:45:59 -0700 | From | Jeremy Fitzhardinge <> | Subject | Re: [PATCH 2/2] xen-netfront: call netif_start_queue() on xennet_open() |
| |
Eduardo Habkost wrote: > xen-netfront was waking the queue before calling netif_start_queue(), > triggering the BUG_ON() on __netif_schedule(). > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > Ok, Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
but Ingo, do you want to pick this up? You're gathering a collection of these patches anyway, or should we kick it over to Dave/Jeff?
J
> --- > drivers/net/xen-netfront.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c > index 902bbe7..c749bdb 100644 > --- a/drivers/net/xen-netfront.c > +++ b/drivers/net/xen-netfront.c > @@ -329,7 +329,7 @@ static int xennet_open(struct net_device *dev) > } > spin_unlock_bh(&np->rx_lock); > > - xennet_maybe_wake_tx(dev); > + netif_start_queue(dev); > > return 0; > } >
| |