Messages in this thread | | | Date | Thu, 24 Jul 2008 04:09:54 -0700 | From | Andrew Morton <> | Subject | Re: [git pull] scheduler updates for v2.6.27, phase #2 |
| |
On Thu, 24 Jul 2008 12:43:13 +0200 Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Mon, 2008-07-21 at 13:16 -0700, Daniel Walker wrote: > > On Mon, 2008-07-21 at 21:23 +0200, Peter Zijlstra wrote: > > > > > Does this work for you? > > > > > > > Yours removed the warning .. I made an alternate one below only compile > > tested, your choice.. > > How about this one - it seems there is a whole scala of new division > instructions these days... :-) >
ain't life grand.
> > > diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c > index 47ceac9..3c38686 100644 > --- a/kernel/sched_rt.c > +++ b/kernel/sched_rt.c > @@ -253,7 +253,7 @@ static int do_balance_runtime(struct rt_rq *rt_rq) > > diff = iter->rt_runtime - iter->rt_time; > if (diff > 0) { > - do_div(diff, weight); > + diff = div_u64((u64)diff, weight);
Can't use div_s64() here?
> if (rt_rq->rt_runtime + diff > rt_period) > diff = rt_period - rt_rq->rt_runtime; > iter->rt_runtime -= diff; >
| |