lkml.org 
[lkml]   [2008]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    SubjectRe: [Bug 11046] New: Kernel bug in mm/bootmem.c on Sparc machines
    From
    From: Andrew Morton <akpm@linux-foundation.org>
    Date: Wed, 23 Jul 2008 20:38:36 -0700

    > So if we're going to change it in 2.6.26, we'll need a separate patch.

    Here is the 2.6.26 version:

    bootmem: Allow zero length reserve and free.

    It's either this or all the call sites explicitly check
    when such a case is possible and sometimes expected.

    Signed-off-by: David S. Miller <davem@davemloft.net>

    diff --git a/mm/bootmem.c b/mm/bootmem.c
    index 8d9f60e..e540f7a 100644
    --- a/mm/bootmem.c
    +++ b/mm/bootmem.c
    @@ -153,7 +153,8 @@ static void __init reserve_bootmem_core(bootmem_data_t *bdata,
    unsigned long sidx, eidx;
    unsigned long i;

    - BUG_ON(!size);
    + if (!size)
    + return;

    /* out of range */
    if (addr + size < bdata->node_boot_start ||
    @@ -187,7 +188,8 @@ static void __init free_bootmem_core(bootmem_data_t *bdata, unsigned long addr,
    unsigned long sidx, eidx;
    unsigned long i;

    - BUG_ON(!size);
    + if (!size)
    + return;

    /* out range */
    if (addr + size < bdata->node_boot_start ||

    \
     
     \ /
      Last update: 2008-07-24 05:45    [W:0.023 / U:0.064 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site