lkml.org 
[lkml]   [2008]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: Kernel WARNING: at net/core/dev.c:1330 __netif_schedule+0x2c/0x98()
    From
    From: Jarek Poplawski <jarkao2@gmail.com>
    Date: Wed, 23 Jul 2008 11:49:14 +0000

    > On Wed, Jul 23, 2008 at 11:35:19AM +0000, Jarek Poplawski wrote:
    > > On Wed, Jul 23, 2008 at 12:58:16PM +0200, Peter Zijlstra wrote:
    > ...
    > > > When I look at the mac802.11 code in ieee80211_tx_pending() it looks
    > > > like it can do with just one lock at a time, instead of all - but I
    > > > might be missing some obvious details.
    > > >
    > > > So I guess my question is, is netif_tx_lock() here to stay, or is the
    > > > right fix to convert all those drivers to use __netif_tx_lock() which
    > > > locks only a single queue?
    > > >
    > >
    > > It's a new thing mainly for new hardware/drivers, and just after
    > > conversion (older drivers effectively use __netif_tx_lock()), so it'll
    > > probably stay for some time until something better is found. David,
    > > will tell the rest, I hope.
    >
    > ...And, of course, these new drivers should also lock a single queue
    > where possible.

    It isn't going away.

    There will always be a need for a "stop all the TX queues" operation.


    \
     
     \ /
      Last update: 2008-07-23 22:19    [W:0.040 / U:0.304 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site