Messages in this thread | | | Subject | Re: [PATCH] cdc-acm: don't unlock acm->mutex on error path | From | Andrei Popa <> | Date | Wed, 23 Jul 2008 16:36:05 +0300 |
| |
It's ok now, thanks.
On Wed, 2008-07-23 at 17:23 +0400, Alexey Dobriyan wrote: > On Wed, Jul 23, 2008 at 03:52:36PM +0300, Andrei Popa wrote: > > I installed gnokii-0.6.22-r2 and gave the command "gnokii --identify" > > and the kernel oopsed: > > > > BUG: unable to handle kernel NULL pointer dereference at 00000458 > > IP: [<c0444b52>] mutex_unlock+0x0/0xb > > [<c03830ae>] acm_tty_open+0x4c/0x214 > > Try this: > > [PATCH] cdc-acm: don't unlock acm->mutex on error path > > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> > --- > > drivers/usb/class/cdc-acm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/usb/class/cdc-acm.c > +++ b/drivers/usb/class/cdc-acm.c > @@ -595,8 +595,8 @@ static int acm_tty_open(struct tty_struct *tty, struct file *filp) > tasklet_schedule(&acm->urb_task); > > done: > -err_out: > mutex_unlock(&acm->mutex); > +err_out: > mutex_unlock(&open_mutex); > return rv; > >
| |