lkml.org 
[lkml]   [2008]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 66/79] always enable FW_LOADER unless EMBEDDED=y
    Date
    From: Adrian Bunk <bunk@kernel.org>

    James Bottomley recently discovered that we have
    {request,release}_firmware() dummies for the case of the actual
    functions not being available and has a fix for the bug that was
    actually causing build errors for built-in users with
    CONFIG_FW_LOADER=m.

    But now missing selects on FW_LOADER are no longer visible at
    compile-time at all and can become runtime problems.

    FW_LOADER is infrastructure with relatively small codesize we can safely
    enable for everyone, and only for people who really need small kernels
    (and can be expected to know what they are doing) it matters being able
    to disable it.

    This patch therefore always sets FW_LOADER=y and allows users only to
    disable it with EMBEDDED=y.

    As a bonus, we can then get rid of all "select FW_LOADER" plus the due
    to it required "depends on HOTPLUG" which removes some complexity from
    our Kconfig files.

    Signed-off-by: Adrian Bunk <bunk@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/base/Kconfig | 3 ++-
    1 files changed, 2 insertions(+), 1 deletions(-)

    diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
    index d47482f..6318f6b 100644
    --- a/drivers/base/Kconfig
    +++ b/drivers/base/Kconfig
    @@ -27,8 +27,9 @@ config PREVENT_FIRMWARE_BUILD
    If unsure say Y here.

    config FW_LOADER
    - tristate "Userspace firmware loading support"
    + tristate "Userspace firmware loading support" if EMBEDDED
    depends on HOTPLUG
    + default y
    ---help---
    This option is provided for the case where no in-kernel-tree modules
    require userspace firmware loading support, but a module built outside
    --
    1.5.6.3


    \
     
     \ /
      Last update: 2008-07-22 07:47    [W:0.019 / U:1.188 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site