Messages in this thread | | | Date | Tue, 22 Jul 2008 21:41:37 -0400 | From | Jack Howarth <> | Subject | Re: [PATCH] x86,pci: dmi check for mackpro 2.2 mmconf |
| |
Jesse, The file /sys/module/pcie_aspm/parameters/policy shows...
[default] performance powersave
Reading the original patch, I don't quite see how it would show the aspm as disabled. I would think the current ASPM fix patch should be modified to output a kernel message that ASPM is being disabled because of pre-1.1 PCIe devices when it does that (assuming it is disabling across the board and not just for a specific device on the bus). Jack
On Tue, Jul 22, 2008 at 06:32:20PM -0700, Jesse Barnes wrote: > On Tuesday, July 22, 2008 6:00 pm Jack Howarth wrote: > > Jesse, > > I found that patch right after I sent the email. Applying the ASPM > > patch solves the boot hangs on under 2.6.26-git9 built with > > CONFIG_PCIEASPM=y. I am attaching the dmesg log for such a boot > > below. I am a little confused if the patch totally disables aspm on > > my machine or just inhibits the hang. Is there a proc entry I can check > > to monitor that aspm is in use? > > It should disable ASPM on pre-1.1 PCIe devices, since apparently many of them > get ASPM wrong, resulting in bus hangs. There's a file in sysfs to control > things: > /sys/module/pcie_aspm/parameters/policy > (see the description in 7d715a6c1ae5785d00fb9a876b5abdfc43abc44b for info). > > With the patch applied hopefully it indicates that things are disabled. > > Thanks for testing. > > Jesse
| |