lkml.org 
[lkml]   [2008]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 37/47] serial8250: sanity check nr_uarts on all paths.
    2.6.25-stable review patch.  If anyone has any objections, please let us
    know.

    ------------------
    From: Eric W. Biederman <ebiederm@xmission.com>

    commit 05d81d2222beec7b63ac8c1c8cdb5bb4f82c2bad upstream

    I had 8250.nr_uarts=16 in the boot line of a test kernel and I had a weird
    mysterious crash in sysfs. After taking an in-depth look I realized that
    CONFIG_SERIAL_8250_NR_UARTS was set to 4 and I was walking off the end of
    the serial8250_ports array.

    Ouch!!!

    Don't let this happen to someone else.

    Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
    Acked-by: Alan Cox <alan@redhat.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/serial/8250.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/serial/8250.c
    +++ b/drivers/serial/8250.c
    @@ -2564,6 +2564,9 @@ static struct console serial8250_console

    static int __init serial8250_console_init(void)
    {
    + if (nr_uarts > UART_NR)
    + nr_uarts = UART_NR;
    +
    serial8250_isa_init_ports();
    register_console(&serial8250_console);
    return 0;
    --


    \
     
     \ /
      Last update: 2008-07-23 01:33    [W:0.040 / U:0.948 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site