lkml.org 
[lkml]   [2008]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] linux-input: bcm5974-0.57: mode-switch to atp_open, cleanup bug fixed
Dmitry,

thank you so much for your answers! I would like to send you
a non-patch of the updated driver shortly if I may; it will
require more testing before submission, but having your blessing
first should make things turn around faster.

> >
> > 3. From the state (!opened,suspended), calling open gets us to what
> > state?
> >

Depens on the kind of suspend - manual suspend will cause open to
fail. Autosuspend (if driver implements it) should resume the device.

[...]

>> 5. From the state (opened,suspended), calling resume fails. What state
>> are we in?
>>
>
> Screwed up ;) From the driver POV still (opened, suspended) I think.
>

I feel a bit reluctant to implement this particular behavior, since it
will leave the device in a bad state; if resume fails and stays suspended,
the device cannot later be opened according to 3). What if a failed
resume leaves the device in state (!opened,!suspended)? It could then
later be reopened.

Cheers,
Henrik Rydberg



\
 
 \ /
  Last update: 2008-07-23 00:21    [W:0.979 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site