lkml.org 
[lkml]   [2008]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -mm] coredump: format_corename: don't append .%pid if multi-threaded
    On Tue, Jul 22, 2008 at 3:02 PM, Oleg Nesterov <oleg@tv-sign.ru> wrote:
    > On 07/22, Michael Kerrisk wrote:
    >>
    >> On Tue, Jul 22, 2008 at 2:43 PM, Oleg Nesterov <oleg@tv-sign.ru> wrote:
    >> >
    >> > That said, this is the user-visible change...
    >>
    >> True. Not sure how important that is in this case though. What is
    >> the reason for making this change (other than tidiness)?
    >
    > Tidiness is the only reason.
    >
    > Please don't hesitate to nack this patch if you think we shouldn't
    > change the historical behaviour, the cleanup is very minor.

    It is hard to think of something that might break because of this, so
    I'll remain silent.

    > As for me, I think it is a bit strange we append "%.pid" depending on
    > is_multithreaded, the same app can have 1 or more threads for various

    Agreed. It is strange.

    Cheers,

    Michael

    > reasons when the coredump happens, but this behaviour is very old and
    > perhaps it is too late to change.
    >
    > Oleg.
    >
    >



    --
    Michael Kerrisk
    Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
    man-pages online: http://www.kernel.org/doc/man-pages/online_pages.html
    Found a bug? http://www.kernel.org/doc/man-pages/reporting_bugs.html


    \
     
     \ /
      Last update: 2008-07-22 16:49    [W:0.023 / U:63.532 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site