Messages in this thread Patch in this message | | | Date | Tue, 22 Jul 2008 13:44:14 +0100 | From | Alan Cox <> | Subject | [PATCH] istallion: Small follow up for the fixes to istallion |
| |
> Fix the compile error which was caused by commit "istallion: use tty_port" and "tty: Ldisc revamp". > Also make the warning silent.
Sorry about that one.
There is a bit more fixing needed as the ldisc reference isn't held during close.
--
istallion: Use helpers
From: Alan Cox <alan@redhat.com>
The ldisc needs to be referenced properly when used. The tty layer has a helper for this which should have been used but this driver got missed originally.
Signed-off-by: Alan Cox <alan@redhat.com> ---
drivers/char/istallion.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/char/istallion.c b/drivers/char/istallion.c index 63d22b5..f9ebcd4 100644 --- a/drivers/char/istallion.c +++ b/drivers/char/istallion.c @@ -925,8 +925,7 @@ static void stli_close(struct tty_struct *tty, struct file *filp) clear_bit(ST_TXBUSY, &portp->state); clear_bit(ST_RXSTOP, &portp->state); set_bit(TTY_IO_ERROR, &tty->flags); - if (tty->ldisc.ops->flush_buffer) - (tty->ldisc.ops->flush_buffer)(tty); + tty_ldisc_flush(tty); set_bit(ST_DOFLUSHRX, &portp->state); stli_flushbuffer(tty);
| |